Moved to allowlist naming; added contributing naming rule about potentially offensive terminology. #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
reviewed
Jun 8, 2020
cmd/thanos/tools_bucket.go
Outdated
| @@ -84,7 +84,7 @@ func registerBucketVerify(m map[string]setupFunc, root *kingpin.CmdClause, name | |||
| Short('r').Default("false").Bool() | |||
| issuesToVerify := cmd.Flag("issues", fmt.Sprintf("Issues to verify (and optionally repair). Possible values: %v", allIssues())). | |||
| Short('i').Default(verifier.IndexIssueID, verifier.OverlappedBlocksIssueID).Strings() | |||
| idWhitelist := cmd.Flag("id-whitelist", "Block IDs to verify (and optionally repair) only. "+ | |||
| idAllowlist := cmd.Flag("id-allowlist", "Block IDs to verify (and optionally repair) only. "+ | |||
There was a problem hiding this comment.
Is there any additional thing even necessary? Just id or ids would be even better no?
|
@brancz I was thinking about another example we use (in Prometheus as well) a lot: Blackbox and whitebox monitoring: What about proposing |
|
💯 |
…tially offensive terminology. Signed-off-by: Bartlomiej Plotka <[email protected]>
povilasv
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartlomiej Plotka [email protected]